Description

Change validation pattern to comply with the automatic generated key.

Related Issue

Closes #96

Type of Change

• [ ] 📚 Examples / docs / tutorials / dependencies update
• [x] 🔧 Bug fix (non-breaking change which fixes an issue)
• [ ] 🥂 Improvement (non-breaking change which improves an existing feature)
• [ ] 🚀 New feature (non-breaking change which adds functionality)
• [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
• [ ] 🔐 Security fix

Checklist

• [x] I've read the CODE_OF_CONDUCT.md document.
• [x] I've read the CONTRIBUTING.md guide.
• [x] I've updated the code style using make codestyle.
• [x] I've written tests for all new methods and classes that I created.
• [x] I've written the docstring in Google format for all the methods and classes that I used.

This step is often taking over 30 seconds. With a simple spinner and no information on the progress, it leads the user to wonder if there is not a bug.

It would be a much better UX to have a % progress information

The PFA file Worker is not found. And the said folder contains various errors when opened in my IDE.

https://github.com/Giskard-AI/giskard/blob/92d1deb14bbe47a7df222def72d5297ce0cbb50f/giskard-server/src/main/java/ai/giskard/ml/MLWorkerClient.java#L10

Description

Related Issue

Type of Change

• [ ] 📚 Examples / docs / tutorials / dependencies update
• [x] 🔧 Bug fix (non-breaking change which fixes an issue)
• [x] 🥂 Improvement (non-breaking change which improves an existing feature)
• [ ] 🚀 New feature (non-breaking change which adds functionality)
• [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
• [ ] 🔐 Security fix

Checklist

• [ ] I've read the CODE_OF_CONDUCT.md document.
• [ ] I've read the CONTRIBUTING.md guide.
• [ ] I've updated the code style using make codestyle.
• [ ] I've written tests for all new methods and classes that I created.
• [ ] I've written the docstring in Google format for all the methods and classes that I used.

Description

• [x] Convert <v-select> to <v-autocomplete> to add simple search to LIME Categories
• [x] Migrate TeamExplanation.vue to use the Composition API
• [x] Add a small doc to help with component migration in the future

Related Issue

#387 #432 => Tick TeamExplanation.vue when merged

Type of Change

• [x] 📚 Examples / docs / tutorials / dependencies update
• [ ] 🔧 Bug fix (non-breaking change which fixes an issue)
• [x] 🥂 Improvement (non-breaking change which improves an existing feature)
• [ ] 🚀 New feature (non-breaking change which adds functionality)
• [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
• [ ] 🔐 Security fix

GSK-348

When selecting the custom filter, and setting:

• Actual labels = 0
• Predicted labels = 1

one of the data entries shown has:

• Actual labels = 0
• Predicted labels = 0

Upon investigation, when we click on Model --> Inspect (i.e. the inspection is done for the whole dataset) this is the data entry in question:

,ETAB_ACT_DATE_DEBUT_ACTIVITE,ETAB_ACT_MODALITE_EXERCICE,GEST_MAJ_DATE,GDP_FLAG_RGE,ENT_ACT_DATE_IMMAT_RM,ENT_ACT_NON_SEDENTAIRE,ENT_GEST_MAJ_DATE,ENT_GEST_NON_DIFFUSION,DIR_ID_NATIONALITE,DIR_ID_DATE_NAISSANCE,DIR_ID_LISTE_DIFFUSION,DIR_ID_DATE_DEBUT_ACTIVITE,DIR_ADR_PAYS,DIR_FOR_FORAIN,DIR_QA_QUALIFICATION,DIR_QA_DATE,DIR_GEST_MAJ_DATE,INTITULE_ORIGINE_ETABLISSEMENT,INTITULE_CATEGORIE_ETABLISSEMENT,ETAB_NON_SEDENTAIRE,ETAB_AUDIT,DIR_CC_PRESENT,DIR_NATION,TYPOLOGIE_URBAIN_RURAL,ENT_ACT_FORME_JURIDIQUE_2
54,13.971252566735114,Permanente,7.468856947296373,0,13.943874058863791,0,7.468856947296373,False,050,70.48596851471595,0,13.971252566735114,FRANCE,0,SANS QUALIFICATION,121.84804928131418,7.468856947296373,Création,Siège et établissement principal,0,1,0,Fr,urbain densité intermédiaire,54,0

and the prediction (for labels [0, 1]) is:

0.49382649000731726,0.5061735099926827

-------------

Now when skimming through the data, i.e. running prediction only on this entry, this is the resulting prediction (for labels [0, 1]) instead is:

0.72773,0.27227

so completely different predictions.

Project: Giskard Reporter: rabah Created: 2022-11-09

Description

Related Issue

Type of Change

• [x] 📚 Examples / docs / tutorials / dependencies update
• [ ] 🔧 Bug fix (non-breaking change which fixes an issue)
• [ ] 🥂 Improvement (non-breaking change which improves an existing feature)
• [ ] 🚀 New feature (non-breaking change which adds functionality)
• [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
• [ ] 🔐 Security fix

Checklist

• [x] I've read the CODE_OF_CONDUCT.md document.
• [x] I've read the CONTRIBUTING.md guide.
• [x] I've updated the code style using make codestyle.
• [x] I've written tests for all new methods and classes that I created.
• [x] I've written the docstring in Google format for all the methods and classes that I used.

Bumps async from 2.6.3 to 2.6.4.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Description

• [x] Change loading from spinner to indefinite progress bar
• [x] Migrate InspectorLauncher.vue to Composition API

Related Issue

#432 => InspectorLauncher.vue migrated

Description

removed httpretty package from poetry requirements

Related Issue

https://giskard.youtrack.cloud/agiles/121-12/current?issue=GSK-395

Type of Change

• [ ] 📚 Examples / docs / tutorials / dependencies update
• [ ] 🔧 Bug fix (non-breaking change which fixes an issue)
• [x] 🥂 Improvement (non-breaking change which improves an existing feature)
• [ ] 🚀 New feature (non-breaking change which adds functionality)
• [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
• [ ] 🔐 Security fix

Description

Related Issue

Type of Change

• [ ] 📚 Examples / docs / tutorials / dependencies update
• [ ] 🔧 Bug fix (non-breaking change which fixes an issue)
• [x] 🥂 Improvement (non-breaking change which improves an existing feature)
• [ ] 🚀 New feature (non-breaking change which adds functionality)
• [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
• [ ] 🔐 Security fix

Checklist

• [x] I've read the CODE_OF_CONDUCT.md document.
• [x] I've read the CONTRIBUTING.md guide.
• [ ] I've updated the code style using make codestyle.
• [ ] I've written tests for all new methods and classes that I created.
• [ ] I've written the docstring in Google format for all the methods and classes that I used.

Description

Added the possibility to rename dataset and models for admin and project owner

Related Issue

Migration of component (https://github.com/Giskard-AI/giskard/issues/432):

• Models.vue
• Datasets.vue

Type of Change

• [ ] 📚 Examples / docs / tutorials / dependencies update
• [ ] 🔧 Bug fix (non-breaking change which fixes an issue)
• [x] 🥂 Improvement (non-breaking change which improves an existing feature)
• [x] 🚀 New feature (non-breaking change which adds functionality)
• [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
• [ ] 🔐 Security fix

Checklist

• [x] I've read the CODE_OF_CONDUCT.md document.
• [x] I've read the CONTRIBUTING.md guide.
• [ ] I've updated the code style using make codestyle.
• [ ] I've written tests for all new methods and classes that I created.
• [ ] I've written the docstring in Google format for all the methods and classes that I used.

Description

Added possibility to delete feedback in the feedbacks list view

Related Issue

N/A

Type of Change

• [ ] 📚 Examples / docs / tutorials / dependencies update
• [ ] 🔧 Bug fix (non-breaking change which fixes an issue)
• [x] 🥂 Improvement (non-breaking change which improves an existing feature)
• [ ] 🚀 New feature (non-breaking change which adds functionality)
• [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
• [ ] 🔐 Security fix

Checklist

• [x] I've read the CODE_OF_CONDUCT.md document.
• [x] I've read the CONTRIBUTING.md guide.
• [ ] I've updated the code style using make codestyle.
• [ ] I've written tests for all new methods and classes that I created.
• [ ] I've written the docstring in Google format for all the methods and classes that I used.

🐛 Bug Report

The settings button shows a blank screen if we save the test suit settings without making any changes.

🔬 How To Reproduce

Steps to reproduce the behavior:

1. Create a test suit however u like.
2. Click on the settings/Edit button and save it without making any changes.
3. Now, if you click the settings button again, it'll show a blank Screen

Screenshots

This is the output after Step-3

📈 Expected behavior

The settings menu should be shown when the button is clicked.

Description

• [x] Migrate Vuex => Pinia
• [ ] Add proper feature management
• [x] Rework the settings view to better split between user settings and general settings
• [ ] Make the frontend use feature flags to hide user management entirely

Related Issue

#614 #432 ==> Components Migrated:

• PasswordRecovery.vue
• ResetPassword.vue
• Signup.vue
• Dashboard.vue
• AdminUsers.vue
• CreateUser.vue
• EditUser.vue
• InviteUsers.vue
• UserProfile.vue
• UserProfileEditPassword.vue
• Project.vue

Type of Change

• [ ] 📚 Examples / docs / tutorials / dependencies update
• [ ] 🔧 Bug fix (non-breaking change which fixes an issue)
• [x] 🥂 Improvement (non-breaking change which improves an existing feature)
• [x] 🚀 New feature (non-breaking change which adds functionality)
• [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
• [ ] 🔐 Security fix

An example of a new API:

Changes implemented in this PR are not backward compatible with the old datasets/models since the storage format has changed

from giskard import Model, SKLearnModel, GiskardClient, Dataset
from giskard.core.core import SupportedModelTypes

clf = ...  # regular model (scikit-learn for example)
df = ...  # pandas dataframe


def my_data_preparation_pipeline(df):
    return df


model = SKLearnModel(model=clf,
                     model_type=SupportedModelTypes.CLASSIFICATION,
                     data_preparation_function=my_data_preparation_pipeline,
                     )
dataset = Dataset(df, name="My Dataset", target="survived")

client = GiskardClient("http://localhost:9000", "API_KEY")

# save model and dataset to Giskard server
mid = model.save(client, "project_key", validate_ds=dataset)
did = dataset.save(client, "project_key")

# load model and dataset from Giskard server
model = Model.load(client, "project_key", mid)
dataset = Model.load(client, "project_key", did)

Internal artifact storage in GISKARD_HOME:

~/giskard-home/projects/mlflow
├── datasets
│   ├── 00c4cf2f1b22404ba5003e2a924ec105
│   │   ├── data.csv.zst
│   │   └── giskard-dataset-meta.yaml
│   └── ff71d57ec278435caf3d31d73c29c3e4
│       ├── data.csv.zst
│       └── giskard-dataset-meta.yaml
└── models
    └── 0c003c62cbe14913a7997887ec1d6a21
        ├── MLmodel
        ├── conda.yaml
        ├── giskard-data-prep.pkl
        ├── giskard-model-meta.yaml
        ├── model.pkl
        ├── python_env.yaml
        └── requirements.txt

• [x] migrated from -h,-p worker cli params to -u and -k for giskard server URL and API Key
• [x] implement Model and Dataset save/load API methods
• [x] fix artifact download from the UI
• [ ] adapt demo projects to the new artifact storage
• [x] fix internal ML Worker startup to work without client