Hello pygsflow team! I'm a reviewer for your submission to JOSS tracked here. I'll use this issue to track my feedback on the paper and software -- feel free to split out my comments into separate issues if that helps your workflow.

README.md

• [x] #13

Paper

• [x] #18
• [x] Paragraph starting on line 62: since you mention external sensitivity analysis software, it could be useful for readers to cite the calibration software typically used in GSFLOW applications

Jupyter notebooks

• [x] #15
• [x] #16
• [x] #17
• [x] #14
• [x] Just wanted to say that the plots in the stream vector notebook are really nice looking!

I am trying to remove parameters from the control file.

I can get_record(name='soilzone_module'):

soilzone_module 1 4 soilzone

But I can't remove_record(name='soilzone_module'):

/home/mrush/miniconda3/lib/python3.8/site-packages/gsflow/param_base.py:211: UserWarning: The record does not exist: soilzone_module warnings.warn("The record does not exist: {}".format(name),

Greetings, pyGSFLOW documentation site has a typo in its text as well as in its page title. It states "Welocme" instead of "Welcome".

PoC: https://pygsflow.github.io/pygsflowdocs/#welocme-to-the-pygsflow-documentation

Hi all, this checklist will contain feedback related to your JOSS Review. I will continue to update this checklist as I move through my review:

Installation

• [x] Indicate which python versions are supported in the README.
• [x] Installation fails from develop branch on Python3.6 with EnvironmentError("pyGSFLOW is only supported with python 3.7 and above"). Please indicate that Python3.6 is not supported in the README.
• [x] Installation fails from develop branch on Python3.7 due to dependency error ERROR: Could not find a version that satisfies the requirement flopy>=3.3.5
• [x] Installation fails from develop branch on Python3.8 due to dependency error ERROR: Could not find a version that satisfies the requirement flopy>=3.3.5
• [x] Installation fails from develop branch on Python3.9 due to dependency error ERROR: Could not find a version that satisfies the requirement flopy>=3.3.5
• [x] Installation fails from develop branch on Python3.10 due to dependency error: ERROR: Could not find a version that satisfies the requirement flopy>=3.3.5
• [x] #24
• [x] #25

Documentation

• [x] Cannot find contributing guidelines in README.
• [x] #23
• [x] #22

Misc

• [x] 'Dependency' issue tag is misspelled.
• [x] #21
• [x] #20

prms_parameter.py currently prints the parameter 'width' attribute (default 10) to the parameter file. These numbers are not required for prms/gsflow.

https://github.com/pygsflow/pygsflow/blob/master/gsflow/prms/prms_parameter.py

Lines 535 and 584

I added the build by default for parameters in the JSON file. I think I am missing a default file that I can upload later, but I put different cases with different dimensions for parameters in the docs of the function

The rasterio wheels on PyPI include HDF5 and netCDF4 shared libraries and they can create conflicts with the netCDF4 wheel.

The proposed workaround is to install rasterio from the source distribution instead of from binary wheel.

pip install netcdf4
pip install --no-binary rasterio rasterio

This method works on all tested sytems (ubuntu, macos, and windows) to avoid binary library conflicts.