I tried to install this on CentOS 7 and got this error:

; pip install udatetime
Collecting udatetime
  Using cached udatetime-0.0.2.tar.gz
Building wheels for collected packages: udatetime
  Running setup.py bdist_wheel for udatetime ... error
  Complete output from command /home/usr/.virtualenvs/mead/bin/python -u -c "im
port setuptools, tokenize;__file__='/tmp/pip-build-1v_otE/udatetime/setup.py';ex
ec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'
), __file__, 'exec'))" bdist_wheel -d /tmp/tmpxo1peqpip-wheel- --python-tag cp27
:
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib.linux-x86_64-2.7
  creating build/lib.linux-x86_64-2.7/udatetime
  copying udatetime/__init__.py -> build/lib.linux-x86_64-2.7/udatetime
  running egg_info
  writing udatetime.egg-info/PKG-INFO
  writing top-level names to udatetime.egg-info/top_level.txt
  writing dependency_links to udatetime.egg-info/dependency_links.txt
  warning: manifest_maker: standard file '-c' not found

  reading manifest file 'udatetime.egg-info/SOURCES.txt'
  reading manifest template 'MANIFEST.in'
  writing manifest file 'udatetime.egg-info/SOURCES.txt'
  running build_ext
  building 'rfc3339' extension
  creating build/temp.linux-x86_64-2.7
  creating build/temp.linux-x86_64-2.7/src
  gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -
fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-swit
ches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall
 -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffe
r-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -
fPIC -I/usr/include/python2.7 -c ./src/rfc3339.c -o build/temp.linux-x86_64-2.7/
./src/rfc3339.o -Ofast
  In file included from /usr/include/python2.7/pyconfig.h:6:0,
                   from /usr/include/python2.7/Python.h:8,
                   from ./src/rfc3339.c:8:
  /usr/include/python2.7/pyconfig-64.h:1182:0: warning: "_POSIX_C_SOURCE" redefi
ned [enabled by default]
   #define _POSIX_C_SOURCE 200112L
   ^
  In file included from /usr/include/math.h:27:0,
                   from ./src/rfc3339.c:1:
  /usr/include/features.h:168:0: note: this is the location of the previous defi
nition
   # define _POSIX_C_SOURCE 200809L
   ^
  In file included from /usr/include/python2.7/pyconfig.h:6:0,
                   from /usr/include/python2.7/Python.h:8,
                   from ./src/rfc3339.c:8:
  /usr/include/python2.7/pyconfig-64.h:1204:0: warning: "_XOPEN_SOURCE" redefine
d [enabled by default]
   #define _XOPEN_SOURCE 600
   ^
  In file included from /usr/include/math.h:27:0,
                   from ./src/rfc3339.c:1:
  /usr/include/features.h:170:0: note: this is the location of the previous defi
nition
   # define _XOPEN_SOURCE 700
   ^
  ./src/rfc3339.c: In function ‘_parse_time’:
  ./src/rfc3339.c:250:9: error: ‘for’ loop initial declarations are only allowed
 in C99 mode
           for (unsigned int i = 0; i < 6; i++) {
           ^
  ./src/rfc3339.c:250:9: note: use option -std=c99 or -std=gnu99 to compile your
 code
  error: command 'gcc' failed with exit status 1

pip install udatetime fails to compile udatetime on Python 3.9. Works fine on 3.8.

Tested on:

• Python 3.9.0 on Ubuntu in Windows Subsystem for Linux on Windows 10
• Python 3.9.0 on Darwin 19.6.0 (MacBook)

Fails with similar errors on both.

$ env39_wsl/bin/pip install udatetime
Collecting udatetime
  Downloading udatetime-0.0.16.tar.gz (13 kB)
Using legacy 'setup.py install' for udatetime, since package 'wheel' is not installed.
Installing collected packages: udatetime
    Running setup.py install for udatetime ... error
    ERROR: Command errored out with exit status 1:
     command: /mnt/c/Users/<redacted>/env39_wsl/bin/python3.9 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-1qm3faee/udatetime/setup.py'"'"'; __file__='"'"'/tmp/pip-install-1qm3faee/udatetime/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-lkuefh40/install-record.txt --single-version-externally-managed --compile --install-headers /mnt/c/Users/<redacted>/env39_wsl/include/site/python3.9/udatetime
         cwd: /tmp/pip-install-1qm3faee/udatetime/
    Complete output (36 lines):
    running install
    running build
    running build_py
    creating build
    creating build/lib.linux-x86_64-3.9
    creating build/lib.linux-x86_64-3.9/udatetime
    copying udatetime/__init__.py -> build/lib.linux-x86_64-3.9/udatetime
    copying udatetime/_pure.py -> build/lib.linux-x86_64-3.9/udatetime
    running egg_info
    writing udatetime.egg-info/PKG-INFO
    writing dependency_links to udatetime.egg-info/dependency_links.txt
    writing top-level names to udatetime.egg-info/top_level.txt
    reading manifest file 'udatetime.egg-info/SOURCES.txt'
    reading manifest template 'MANIFEST.in'
    writing manifest file 'udatetime.egg-info/SOURCES.txt'
    running build_ext
    building 'udatetime.rfc3339' extension
    creating build/temp.linux-x86_64-3.9
    creating build/temp.linux-x86_64-3.9/src
    x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security
 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -D_PYTHON3=1 -I/mnt/c/Users/<redacted>/env39_wsl/include -I/usr/
include/python3.9 -c ./src/rfc3339.c -o build/temp.linux-x86_64-3.9/./src/rfc3339.o -Ofast -std=c99
    ./src/rfc3339.c: In function ‘_gettime’:
    ./src/rfc3339.c:100:18: error: storage size of ‘t’ isn’t known
         struct timeb t;
                      ^
    ./src/rfc3339.c:101:5: warning: implicit declaration of function ‘ftime’; did you mean ‘stime’? [-Wimplicit-function-declaration]
         ftime(&t);
         ^~~~~
         stime
    ./src/rfc3339.c:100:18: warning: unused variable ‘t’ [-Wunused-variable]
         struct timeb t;
                      ^
    ./src/rfc3339.c: At top level:
    ./src/rfc3339.c:516:21: warning: ‘CAPI’ initialized and declared ‘extern’
     extern RFC3999_CAPI CAPI = {
                         ^~~~
    error: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1
    ----------------------------------------
ERROR: Command errored out with exit status 1: /mnt/c/Users/<redacted>/env39_wsl/bin/python3.9 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-1qm3faee/udatetime/setup.py'"'"'; __file__='"'"'/tmp/pip-install-1qm3faee/udatetime/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-lkuefh40/install-record.txt --single-version-externally-managed --compile --install-headers /mnt/c/Users/<redacted>/env39_wsl/include/site/python3.9/udatetime Check the logs for full command output.

Hi!

The udatetime package installs the rfc3339 module at the top-level, effectively shadowing the rfc3339 Python package. Do you think it is possible to move the rfc3339 module under udatetime?

I use ipython's timeit to benchmark udatetime like:

%timeit -n 1000000 -r 10 udatetime.utcnow()

when i repeat this command 5 times, it block serveral seconds and print : Segmentation fault (core dumped)

datetime library is ok

udatetime version 0.13 leaks memory when calling from_string.

Example (Python 2.7):

import udatetime

s = u"2008-09-08T22:47:31-07:00"
while True:
    t = udatetime.from_string(s)

The pure python version of from_string does not leak, only the C-extension (from_rfc3339_string) does.

Please check using i.e. htop:

#!/usr/bin/python3

-- coding:utf8 --

import udatetime while True: udatetime.now()

It eats megabytes in seconds. I use your library, beacause it's very fast - but this problem was pretty hard to find.

Sincerely Gregory

Currently only 3 and 6 digit fraction seconds are supported:

time-secfrac can be either 3DIGIT for milliseconds or 6DIGIT for microseconds

So 2 digit ones fail:

In [1]: import udatetime

In [2]: udatetime.from_string("2016-07-15T12:33:20.123000+02:00")
Out[2]: datetime.datetime(2016, 7, 15, 12, 33, 20, 123000, tzinfo=+02:00)

In [3]: udatetime.from_string("2016-07-15T12:33:20.123000Z")
Out[3]: datetime.datetime(2016, 7, 15, 12, 33, 20, 123000, tzinfo=+00:00)

In [4]: udatetime.from_string("2016-07-15T12:33:20.12Z")
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-4-240aac401a4c> in <module>()
----> 1 udatetime.from_string("2016-07-15T12:33:20.12Z")

ValueError: Invalid RFC3339 date-time string. Time invalid.

I don't control data source so to use udatetime I would need to do string conversion which might eat all performance benefits. Would it be possible to support any fraction seconds up to 6 digits?

It looks like udatetime does not handle changing utc offset for daylight savings time at different times of year, so the unit tests that use local timezone are failing when run in US Eastern Timezone.

Here is the problem: https://github.com/freach/udatetime/blob/master/src/rfc3339.c#L74 udatetime uses the same UTC offset (in my case -4) for all dates, but datetime correctly uses -5 in January and -4 in August

In[2]: import udatetime
In[3]: from datetime import datetime

In[4]: udatetime.fromtimestamp(1471046400)
Out[4]: datetime.datetime(2016, 8, 12, 20, 0, tzinfo=--4:00)
In[5]: datetime.fromtimestamp(1471046400)
Out[5]: datetime.datetime(2016, 8, 12, 20, 0)

In[6]: udatetime.fromtimestamp(1451606400)
Out[6]: datetime.datetime(2015, 12, 31, 20, 0, tzinfo=--4:00)
In[7]: datetime.fromtimestamp(1451606400)
Out[7]: datetime.datetime(2015, 12, 31, 19, 0)

In[8]: udatetime.fromtimestamp(0)
Out[8]: datetime.datetime(1969, 12, 31, 20, 0, tzinfo=--4:00)
In[9]: datetime.fromtimestamp(0)
Out[9]: datetime.datetime(1969, 12, 31, 19, 0)

Recommend changing the unit tests to avoid this problem buy using utcfromtimestamp() in the tests that do not supply a timestamp.

In future, consider avoiding the problem entirely by always assuming that any datetime that does not come with an explicit timezone offset is UTC and never use the local timezone implicitly. Since this library is all about high performance for high volume throughput, it seems likely that most use cases will be using UTC anyway.

Needed to build on Python 3.9.

Fixes: #32

Can't see what changed in the Python 3.9 headers, where this used to be transitively included and isn't any more.

Note, ftime() is deprecated, and should be replaced with gettimeofday(). This PR does not do that.

udatetime uses the pow() math function in src/rfc3339.c, but doesn't link with libm.so.

This was reported on Debian issue #954305, which also contains a possible fix.

It would be nice to have some faster timestamp generation that one get from pure datetime.timestamp() or time.time(). It can be very useful for any logging, etc. in case of fast application (like load testing using locust.io)

When you try to pickle a datetime object, you get this error:

>>> import udatetime
>>> import pickle
>>> d = udatetime.now()
>>> pickle.dumps(d)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
_pickle.PicklingError: Can't pickle <class 'rfc3339.FixedOffset_type'>: attribute lookup FixedOffset_type on rfc3339 failed

Cannot use copy.deepcopy for datetime objects created with udatetime as deepcopy fails for rfc3339.FixedOffset_type. Example:

>>> import udatetime
>>> import datetime
>>> import pytz
>>> from copy import deepcopy
>>> dtu = udatetime.now()
>>> # deepcopy fails
... deepcopy(dtu)
Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
  File "/usr/local/lib/python3.7/copy.py", line 180, in deepcopy
    y = _reconstruct(x, memo, *rv)
  File "/usr/local/lib/python3.7/copy.py", line 274, in _reconstruct
    y = func(*args)
  File "/usr/local/lib/python3.7/copy.py", line 273, in <genexpr>
    args = (deepcopy(arg, memo) for arg in args)
  File "/usr/local/lib/python3.7/copy.py", line 180, in deepcopy
    y = _reconstruct(x, memo, *rv)
  File "/usr/local/lib/python3.7/copy.py", line 274, in _reconstruct
    y = func(*args)
TypeError: function takes exactly 1 argument (0 given)
>>> deepcopy(dtu.tzinfo)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.7/copy.py", line 180, in deepcopy
    y = _reconstruct(x, memo, *rv)
  File "/usr/local/lib/python3.7/copy.py", line 274, in _reconstruct
    y = func(*args)
TypeError: function takes exactly 1 argument (0 given)
>>> # compared to e.g. pytz as tzinfo
... tz = pytz.timezone('Europe/Helsinki')
>>> dt = tz.localize(dtu.replace(tzinfo=None))
>>> deepcopy(dt)
datetime.datetime(2018, 7, 6, 19, 0, 32, 153444, tzinfo=<DstTzInfo 'Europe/Helsinki' EEST+3:00:00 DST>)

Using e.g. pytz as tzinfo works fine. Using: Python 3.7.0 udatetime 0.0.16

Durations:

   dur-second        = 1*DIGIT "S"
   dur-minute        = 1*DIGIT "M" [dur-second]
   dur-hour          = 1*DIGIT "H" [dur-minute]
   dur-time          = "T" (dur-hour / dur-minute / dur-second)
   dur-day           = 1*DIGIT "D"
   dur-week          = 1*DIGIT "W"
   dur-month         = 1*DIGIT "M" [dur-day]
   dur-year          = 1*DIGIT "Y" [dur-month]
   dur-date          = (dur-day / dur-month / dur-year) [dur-time]

   duration          = "P" (dur-date / dur-time / dur-week)



Klyne, et. al.              Standards Track                    [Page 13]

RFC 3339       Date and Time on the Internet: Timestamps       July 2002


Periods:

   period-explicit   = iso-date-time "/" iso-date-time
   period-start      = iso-date-time "/" duration
   period-end        = duration "/" iso-date-time

   period            = period-explicit / period-start / period-end

The usage of the "tm_gmtoff" field in tm struct (src/rfc3339.c) is currently only supported by POSIX systems. For cross-platform compatibility fallbacks should be offered.