PluginBase seems to break PyYAML, causing ImportErrors on import.
I'm using the latest version of PyYAML (3.11) and PluginBase.
Tested on OS X and Linux.

Importing PluginBase first causes errors:

Python 2.7.3 (default, Mar 18 2014, 05:13:23) 
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import pluginbase
>>> import yaml
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/pluginbase.py", line 404, in plugin_import
    fromlist, level)
  File "/usr/local/lib/python2.7/dist-packages/yaml/__init__.py", line 2, in <module>
    from error import *
  File "/usr/local/lib/python2.7/dist-packages/pluginbase.py", line 404, in plugin_import
    fromlist, level)
ImportError: No module named error

Importing YAML first works fine:

Python 2.7.3 (default, Mar 18 2014, 05:13:23) 
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import yaml
>>> import pluginbase

Exception ignored in: <bound method PluginSource.__del__ of <pluginbase.PluginSource object at 0x7f1a4e229be0>>
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/pluginbase.py", line 247, in __del__
  File "/usr/lib/python3.4/site-packages/pluginbase.py", line 303, in cleanup
  File "/usr/lib/python3.4/site-packages/pluginbase.py", line 318, in __cleanup
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

Not sure of the exact cause yet, but running the following source on python 3.4:

from pluginbase import PluginBase
a_base = PluginBase('some')
a_source = a_base.make_plugin_source(searchpath=['.'])

import asyncio

@asyncio.coroutine
def what():
    return

results in the following warning being displayed:

Exception ignored in: <bound method PluginSource.__del__ of <pluginbase.PluginSource object at 0x021F0AF0>>
Traceback (most recent call last):
  File "d:\python34\lib\site-packages\pluginbase.py", line 247, in __del__
  File "d:\python34\lib\site-packages\pluginbase.py", line 303, in cleanup
  File "d:\python34\lib\site-packages\pluginbase.py", line 319, in __cleanup
KeyError: ('pluginbase._internalspace._spf57aab93650650e4c1433e9cb9bd5a38',)

Could potentially be fixed by adding a default None to the _sys.modules.pop() call causing the KeyError.

Would it be possible to add a recursion depth for the search path?

my_program.py
plugins
    - plugin 1
        - foo.py
        - bar.py
    - plugin 2
        - foobar.py

Currently I am scanning plugins with os.listdir, and searchpathing each. Having a recursion depth would be great.

Raises "AttributeError: 'module' object has no attribute 'choice'" on python2 (2.7.10) because module name (of random plugin) conflicts with python's random module.

from pyvirtualdisplay import Display
  File "/Users/dev/.virtualenvs/kraken-32/lib/python2.7/site-packages/pluginbase.py", line 404, in plugin_import
    fromlist, level)
  File "/Users/dev/.virtualenvs/kraken-32/lib/python2.7/site-packages/pyvirtualdisplay/__init__.py", line 1, in <module>
    from display import Display
  File "/Users/dev/.virtualenvs/kraken-32/lib/python2.7/site-packages/pluginbase.py", line 404, in plugin_import
    fromlist, level)
ImportError: No module named display

The modules with same names in different plugin directory won't be returned in list_plugins.

Here is my case, I have a plugins directory structure like this,

plugins
├── __init__.py
├── builtin
│   ├── __init__.py
│   ├── logger
│   │   ├── __init__.py
│       ├── setup.py
│   │   └── logger.py
├── device
│   ├── __init__.py
│   ├── setup.py

Expect

The list_plugins returns all the module names including those with the same name and could be load_plugin correctly. ['logger', 'setup', 'setup']

Actual

The list_plugins returns all the unique names only and could be load_plugin correctly. ['logger', 'setup']

Code

plugin_base = PluginBase(package='app.plugins',
                            searchpath=[get_path('plugins/builtin')])

source = plugin_base.make_plugin_source(
    searchpath=[get_path('./plugins/%s/' % name)],
    identifier=self.name)
print source.list_plugins()

c:\python\python37\lib\site-packages\pluginbase.py:439: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses

get_searchpath method(in pluginbase.py) is not returning all the sub-directories in the given path.This fix gives the subdirectories as well. For example , for the below directory structure, the current code in get_searchpath is not returning all the sub-directories. app1

• app2 -test2.py
• test1.py app3 -app4
  • test4.py
• test3.py

It has been fixed in this commit.

$ tree -I 'venv|.git|__pycache__'
.
├── app.py
└── sources
    ├── one.py
    └── two.py

from pluginbase import PluginBase

plugin_base = PluginBase(package='app.sources')
plugin_source = plugin_base.make_plugin_source(searchpath=['./sources'])

for plugin_name in plugin_source.list_plugins():
    print(plugin_name)

And when running app.py, I see:

:!/usr/bin/env python app.py
one
two
one
two

If you could kindly point out the error I'm most definitely making, that'd be cool.

when I have:

from pluginbase import PluginBase
from pyechonest import config
from pyechonest import song

I get

Traceback (most recent call last):
  File "partyled.py", line 9, in <module>
    from pyechonest import song
  File "/usr/local/lib/python2.7/site-packages/pluginbase.py", line 404, in plugin_import
    fromlist, level)
  File "build/bdist.macosx-10.10-x86_64/egg/pyechonest/song.py", line 12, in <module>
  File "/usr/local/lib/python2.7/site-packages/pluginbase.py", line 404, in plugin_import
    fromlist, level)
ImportError: No module named util

however if I change the order to

from pyechonest import config
from pyechonest import song
from pluginbase import PluginBase

things work fine. Given the order in which things override, I'm inclined to suspect of PluginBase of doing something weird here.